Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IYY-279: Visitors can listen to Posts - aka Audio player component #468

Open
wants to merge 28 commits into
base: iyy
Choose a base branch
from

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Feb 6, 2025

IYY-279: Visitors can listen to Posts - aka Audio player component

Description of work

Testing Link(s)

Functional Review Steps

iyy-audio-on-posts.mp4

Design Review

  • Verify the designs match the Audio Player Figma Designs
  • Note: I added volume control as both a usability and accessibility enhancment

Accessibility Review

  • Verify the component meets Accessibility requirements

@joetower joetower self-assigned this Feb 6, 2025
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for dev-component-library-twig ready!

Name Link
🔨 Latest commit 308da5d
🔍 Latest deploy log https://app.netlify.com/sites/dev-component-library-twig/deploys/67bf8d4efbaead0008b157a9
😎 Deploy Preview https://deploy-preview-468--dev-component-library-twig.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joetower joetower changed the title feat(IYY-279): add initial themed audio player audio component IYY-279: Visitors can listen to Posts - aka Audio player component Feb 7, 2025
@joetower joetower marked this pull request as ready for review February 10, 2025 23:22
Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well. A few notes:

  • I can't see the progress line or volume line that shows up in your video. The controls still work though. See screenshot.
  • On mobile, volume doesn't work at all. Desktop works fine. I suspect since you have mobile physical volume controls that isn't a problem, but what do you think about hiding it on mobile?

Screenshot 2025-02-10 at 4 05 50 PM

@joetower
Copy link
Contributor Author

joetower commented Feb 11, 2025

@codechefmarc Oh, I see. I'll test this in Chrome and figure out those bugs.

Also, on mobile, on Android the volume controls work as they should. I will test on an iPhone (assuming you tested on an iPhone?), though. Thank you!

@codechefmarc
Copy link
Contributor

Also, on mobile, on Android the volume controls work as they should. I will test on an iPhone (assuming you tested on an iPhone?), though. Thank you!

Ahh yup, I tested on an iPhone, I should have said. :)

@joetower
Copy link
Contributor Author

@codechefmarc Thank you! Apparently, Apple don't allow programmatic adjustments to volume. So, it looks like iPhones are limited to using the physical volume buttons.

It does make me wonder if we should hide playback speed and volume on mobile.

@codechefmarc
Copy link
Contributor

The playback speed worked fine for me on iOS, but, the target was a bit small to tap is all.

@joetower
Copy link
Contributor Author

@codechefmarc Could you please give this another look? On mobile, I made both the track and the thumb/dial thicker and easier to move with your thumb.

On iOS, the volume slider is now hidden.

@duncancm9 duncancm9 changed the base branch from develop to iyy February 25, 2025 23:27
Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring to @miketullo95 for ultimate verification, but I noticed that the icon next to the speed is clickable, but the actual 1.0x is not to change it? Should this whole "box" be clickable to change the speed?

@dblanken-yale
Copy link
Contributor

Also some hover elements don't change mouse icon; should they? Like hovering over the play/pause or the speed so you know you can click it? Also deferring. :)

@dblanken-yale
Copy link
Contributor

Oh, if the audio is finished playing, the pause button stays up, and if you change the location of the audio afterward, it does not continue playing. Should it reset to a play button icon to show it's not playing any more?

@dblanken-yale
Copy link
Contributor

Screen.Recording.2025-03-05.at.11.29.20.AM.mov

Here is a video showing most all of that above. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants