Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IYY-279: Visitors can listen to Posts - aka Audio player component #307

Open
wants to merge 5 commits into
base: iyy
Choose a base branch
from
Open

IYY-279: Visitors can listen to Posts - aka Audio player component #307

wants to merge 5 commits into from

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Feb 7, 2025 •
edited
Loading

@joetower joetower self-assigned this Feb 7, 2025
@joetower joetower mentioned this pull request Feb 10, 2025
Open
10 tasks
@joetower joetower mentioned this pull request Feb 10, 2025
Open
10 tasks
@joetower joetower marked this pull request as ready for review February 10, 2025 23:22
codechefmarc
codechefmarc approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wiring looks good to me! Approved!

dblanken-yale
dblanken-yale approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wireup looks good!

@dblanken-yale
Copy link
Contributor

Oh don't forget to add this to the iyy branch unless you're waiting to merge till after our first release.

@joetower
Copy link
Contributor Author

joetower commented Feb 11, 2025 •
edited
Loading

@dblanken-yale I've been using develop until we know for sure where to put this. 👍 I'll change this to iyy. Thank you!

@duncancm9 duncancm9 changed the base branch from develop to iyy February 25, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codechefmarc codechefmarc codechefmarc approved these changes

@dblanken-yale dblanken-yale dblanken-yale approved these changes

@duncancm9 duncancm9 Awaiting requested review from duncancm9

Assignees

@joetower joetower

Labels
needs review pass code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joetower @dblanken-yale @codechefmarc