Skip to content

Experimenting with a more reliable graphical header layout? #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xenodium wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Experimenting with a more reliable graphical header layout? #276

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
334ec21
Experimenting with a more reliable graphical header layout?
xenodium Feb 9, 2026
54a5563
Trim leading body newlines
xenodium Feb 10, 2026
1ecd6a6
Revert trim leading body newlines commit (unrelated to branch)
xenodium Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions agent-shell.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2238,7 +2238,8 @@ The model contains all inputs needed to render the graphical header."
(:mode-name . ,mode-name)
(:directory . ,default-directory)
(:frame-width . ,(frame-pixel-width))
(:font-height . ,(default-font-height))
(:font-height . ,(frame-char-height))
(:font-size . ,(font-get (face-attribute 'default :font) :size))
(:background-mode . ,(frame-parameter nil 'background-mode))
(:status-frame . ,(agent-shell--status-frame))
(:qualifier . ,qualifier)
Expand Down Expand Up @@ -2294,18 +2295,23 @@ BINDINGS is a list of alists defining key bindings to display, each with:
(setq agent-shell--header-cache (make-hash-table :test #'equal)))
(map-elt agent-shell--header-cache cache-key))))
(or cached
(let* ((image-height (* 3 (map-elt header-model :font-height)))
(let* ((char-height (map-elt header-model :font-height))
(font-size (map-elt header-model :font-size))
(has-bindings (or bindings qualifier))
(image-height (* 3 char-height))
(image-width image-height)
(text-height 25)
(text-height char-height)
(row-spacing 0) ; Spacing between icon/text rows and bindings row
(icon-text-row-height image-height)
(bindings-row-height (if (or bindings qualifier) text-height 0))
(total-height (+ icon-text-row-height bindings-row-height 10))
(bindings-row-height (if has-bindings text-height 0))
(total-height (+ icon-text-row-height bindings-row-height text-height))
;; Y positions for each row (baseline positions for text)
(icon-y 0)
(icon-text-y text-height)
;; Bindings positioned right after the bottom text (2 text lines) plus spacing
(bindings-y (+ (* 3 text-height) row-spacing))
(icon-text-y (if has-bindings
char-height
(+ char-height (/ (- char-height font-size) 2))))
;; Bindings positioned below the icon area
(bindings-y (+ image-height font-size row-spacing))
(svg (svg-create (map-elt header-model :frame-width) total-height))
(icon-filename
(if (map-elt header-model :icon-name)
Expand All @@ -2321,7 +2327,8 @@ BINDINGS is a list of alists defining key bindings to display, each with:
;; Top text line
(svg--append svg (let ((text-node (dom-node 'text
`((x . ,(+ image-width 10))
(y . ,icon-text-y)))))
(y . ,icon-text-y)
(font-size . ,font-size)))))
;; Agent name
(dom-append-child text-node
(dom-node 'tspan
Expand Down Expand Up @@ -2366,12 +2373,14 @@ BINDINGS is a list of alists defining key bindings to display, each with:
;; Bottom text line
(svg-text svg (string-remove-suffix "/" (abbreviate-file-name (map-elt header-model :directory)))
:x (+ image-width 10) :y (+ icon-text-y text-height)
:font-size font-size
:fill (face-attribute 'font-lock-string-face :foreground))
;; Bindings row (last row if bindings or qualifier present)
(when (or bindings qualifier)
(svg--append svg (let ((text-node (dom-node 'text
`((x . 0)
(y . ,bindings-y))))
(y . ,bindings-y)
(font-size . ,font-size))))
(first t))
;; Add qualifier if present
(when qualifier
Expand Down