Skip to content

Conversation

@xenodium
Copy link
Owner

@xenodium xenodium commented Feb 9, 2026

Looking into graphical header improvements for #275

@nhojb
Copy link
Contributor

nhojb commented Feb 9, 2026

Thanks for the comment on #275. Much better to use the current char/font-height than rely on my hard-coded values. I did wonder about that after I submitted my PR 🤷‍♂️

I think the changes in #276 generally work well. Couple of niggles:

  • There's perhaps a little too much bottom padding in shell mode
  • There's a slight jump in the header text y-position when toggling between shell and viewport modes (see screen-recording).

I don't mind looking into the above. But equally happy if you want to continue.

Screen.Recording.2026-02-09.at.17.39.17.mov

@xenodium
Copy link
Owner Author

xenodium commented Feb 9, 2026

Yup. Feel free to take a look. Happy for you to take over the PR if you'd like. We may have to apply whatever we arrive to on both of our ends to get some coverage (we have slightly different setups).

BTW, you may have noticed I have the same background color throughout, so it's good that you have a different header background color.

@xenodium
Copy link
Owner Author

xenodium commented Feb 9, 2026

ps. There's also a text-based header if you'd like that as an alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants