Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Fix compiler issues for Xcode 16 Support #856

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fix compiler issues for Xcode 16 Support #856

merged 2 commits into from
Sep 12, 2024

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Sep 10, 2024

This is a fix for compiler errors for Xcode 16 support.

I used WordPress-iOS as an example wordpress-mobile/WordPress-iOS#23497. They have already made this fix since they copied these dependencies on the repository.


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

Sorry, something went wrong.

@staskus staskus added the enhancement New feature or request label Sep 10, 2024
@itsmeichigo itsmeichigo self-assigned this Sep 12, 2024
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As tested in woocommerce/woocommerce-ios#13911, this compiles on both Xcode 15.3 and 16.1 Beta. LGTM :shipit:

@staskus staskus merged commit 10ea63e into trunk Sep 12, 2024
10 checks passed
@staskus staskus deleted the xcode-16-support branch September 12, 2024 06:40
@itsmeichigo itsmeichigo mentioned this pull request Sep 13, 2024
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants