Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 16 Support #13911

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Xcode 16 Support #13911

merged 5 commits into from
Sep 12, 2024

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Sep 10, 2024

Related WordPressAuthenticator PR: wordpress-mobile/WordPressAuthenticator-iOS#856
Related AutomatticAbout PR: Automattic/AutomatticAbout-Swift#10

Description

Updated dependencies so the project would compile for Xcode 16.

There's still some work required for proper Xcode 16 SDK, especially around new iPadOS tabs. #13910

Steps to reproduce

  1. Open a project with this branch on both Xcode 15 and Xcode 16
  2. Confirm that the project runs without compiler issues

Testing information

There are no functionality changes, only 2 fixes to satisfy the compiler. These changes were already integrated in the WordPress-iOS app for several months.

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.ordPre

@staskus staskus added the type: task An internally driven task. label Sep 10, 2024
@staskus staskus added this to the 20.4 milestone Sep 10, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 10, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr13911-5d9bdda
Version20.3
Bundle IDcom.automattic.alpha.woocommerce
Commit5d9bdda
App Center BuildWooCommerce - Prototype Builds #10826
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and confirmed that the changes compile for both Xcode 15.3 and Xcode 16.1 Beta 👍

@staskus
Copy link
Contributor Author

staskus commented Sep 12, 2024

@itsmeichigo thanks for the review! Forgot to mention that there's also a related PR on WP-Authenticator that needs to be reviewed wordpress-mobile/WordPressAuthenticator-iOS#856

@itsmeichigo
Copy link
Contributor

@staskus I just approved that PR as well.

@staskus staskus enabled auto-merge September 12, 2024 06:55
@staskus staskus disabled auto-merge September 12, 2024 06:55
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 20.4. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@staskus staskus added the iOS 18 label Sep 12, 2024
@staskus staskus enabled auto-merge September 12, 2024 07:00
@staskus staskus merged commit 9f395a4 into trunk Sep 12, 2024
18 checks passed
@staskus staskus deleted the task/xcode-16-support branch September 12, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS 18 type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants