-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 16 Support #13911
Xcode 16 Support #13911
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested and confirmed that the changes compile for both Xcode 15.3 and Xcode 16.1 Beta 👍
@itsmeichigo thanks for the review! Forgot to mention that there's also a related PR on WP-Authenticator that needs to be reviewed wordpress-mobile/WordPressAuthenticator-iOS#856 |
@staskus I just approved that PR as well. |
Related WordPressAuthenticator PR: wordpress-mobile/WordPressAuthenticator-iOS#856
Related AutomatticAbout PR: Automattic/AutomatticAbout-Swift#10
Description
Updated dependencies so the project would compile for Xcode 16.
There's still some work required for proper Xcode 16 SDK, especially around new iPadOS tabs. #13910
Steps to reproduce
Testing information
There are no functionality changes, only 2 fixes to satisfy the compiler. These changes were already integrated in the WordPress-iOS app for several months.
Screenshots
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: