[Shipping labels] Add endpoint to fetch shipments #13995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new data store specifically for WooShipping config, allowing to observe and save the configuration for a specific order.
irfano
added
type: task
irfano
commented
Apr 30, 2025
| ) { | ||
| suspend operator fun invoke(order: Order): List<ShippableItemModel> { | ||
| val refunds = orderDetailRepository.getOrderRefunds(order.id) | ||
| val noRefundedProducts = refunds.getNonRefundedProducts(order.items) | ||
|
|
||
| val shipments = configDataStore.observeConfig(order.id).first()?.shipments // TODO Use this in the UI |
There was a problem hiding this comment.
You can test the output of this PR by debugging this shipment.
irfano
commented
Apr 30, 2025
There was a problem hiding this comment.
I renamed this file because it was storing StoreOptions, not Configuration.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
irfano
force-pushed
the
issue/WOOMOB-416-split-shipment-config-endpoint
branch
from
dd100e8 to
753c079
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13995 +/- ##
============================================
- Coverage 38.27% 38.26% -0.01%
- Complexity 9488 9490 +2
============================================
Files 2118 2119 +1
Lines 116345 116394 +49
Branches 14933 14937 +4
============================================
+ Hits 44532 44542 +10
- Misses 67743 67781 +38
- Partials 4070 4071 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the config endpoint to fetch shipments. It does not include any UI changes.
New endpoint: GET
/wp-json/wcshipping/v1/config/label-purchase/$orderIdI decided to fetch the config endpoint (which includes shipments data) on the order detail screen and cache the response. Later, we’ll use the shipments data on this screen. Then, on the create shipment screen, I’ll use the cached shipments and won’t fetch them again. This is consistent with how the shipment screen handles order data.
Steps to reproduce
You can debug and check the
shipmentsparameter added in this PR to verify that the shipments are fetched successfully.RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: