-
Notifications
You must be signed in to change notification settings - Fork 131
[Shipping labels] Use fetched shipments in split shipment screen #13998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: issue/WOOMOB-416-split-shipment-config-endpoint
Are you sure you want to change the base?
[Shipping labels] Use fetched shipments in split shipment screen #13998
Conversation
@@ -407,10 +409,10 @@ class WooShippingLabelCreationViewModel @Inject constructor( | |||
else -> AddressStatus.UNVERIFIED | |||
} | |||
|
|||
shippableItems.value = items | |||
shippableItems.value = shipments.value.map { it.items }.flatten() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I used flatten()
to display all items on the creation screen, since the creation screen doesn’t support shipments yet.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## issue/WOOMOB-416-split-shipment-config-endpoint #13998 +/- ##
==================================================================================
Coverage 38.26% 38.27%
- Complexity 9490 9495 +5
==================================================================================
Files 2119 2120 +1
Lines 116394 116405 +11
Branches 14937 14939 +2
==================================================================================
+ Hits 44542 44552 +10
+ Misses 67781 67780 -1
- Partials 4071 4073 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes WOOMOB-416
Description
This completes the UI parts of fetching shipments from the backend.
Warning
Review #13995 first.
Steps to reproduce
Testing information
The tests that have been performed
Steps above
Images/gif
after.webm
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: