Repository navigation
feat(automations): conditions timing and validation (3/6) - #1649
Closed
yehonatanpeleg wants to merge 155 commits into
Closed
yehonatanpeleg wants to merge 155 commits into
yehonatanpeleg wants to merge 155 commits into
Conversation
This was referenced Oct 7, 2026
yehonatanpeleg
marked this pull request as ready for review
October 7, 2026 12:05
yehonatanpeleg
added this pull request to stack #1658
October 7, 2026 12:06
Contributor
⏱ EvalForge YAML Gate: Comparison Timed OutcomparisonGroupId: 06dc95a4-15c6-43a2-8b5b-f88dc9986d3b |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ions-skills-3-conditions
main's tree equals part 1's final head, so this merge keeps part 2's content unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… source Merges main and re-exports stage 2 from the canonical source: - the entry guide keeps its final title and slug (build-and-manage-wix-automations) in every scenario and link; - stage 2 keeps part 1's merged activation-status guidance instead of an older copy; - stage 2 drops the update-preservation and ACTIVE-validation sentences; - the three create scenarios use the built-in Show in Inbox action, because the eval templates have no CRM Tasks app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e procedure (2/6) Re-exported from the canonical source: the create read-back step now runs Get Automation as its own call after Create and keeps the returned automation as the evidence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…efusal scenario (2/6) Re-exported from the canonical source after the skill-review advisories: - the entry guide tells the agent not to repeat rollout terms (stage, not yet published) to the user and to explain limits in product terms; - the scope is stated once at the top of the entry guide; - new scenario create-and-activate-request checks that a save-and-turn-on request is saved inactive with Activate explained. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Re-exported from the canonical source: the create hand-off opens with saved-and-inactive and how to turn it on (Activate, edit link) before the details. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…te evidence (2/6) Re-exported from the canonical source: stage 2 says to create a turn-on request INACTIVE and point to Activate; the create scenarios read-back judges check the Create request, a separate Get and the answer, since judges do not see tool response bodies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ow in Inbox (2/6) Re-exported from the canonical source: the status guide ends a multiple-match listing with a direct question, the create hand-off has a concrete first line, and the Inbox scenarios name the Show in Inbox step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Re-exported from the canonical source: the stage-2 scope explains that the guide has no update or status-change procedure and forbids Update even for explicit turn-on requests or repairs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… (2/6) Re-exported from the canonical source (wix-private/crm-automations-client#14563). Addresses review: stage 2 now publishes the full activation guide (turn on/off on request) instead of refusing, the status guide shows its Query/Get/PATCH calls, and the four stage-2 create scenarios use plain user prompts that do not name the action or fields. create-and-activate-request now expects the automation to end up active. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…rder (2/6) Re-exported from wix-private/crm-automations-client#14563: the hand-off for a turned-on automation opens with its ID, and the activation judge requires Validate only before the Update. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…(2/6) Re-exported from wix-private/crm-automations-client#14563 after running the skill-review agent locally: site lock asks only when the site is ambiguous, opaque widgets defined, read-only capability route, full status-call URLs, new deactivate-request scenario, create judges require Validate before Create. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…nistic deactivate seed (2/6) Re-exported from wix-private/crm-automations-client#14563: last local skill-review round (advisories only). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…a separate Validate; ID on the first hand-off line (2/6) Re-exported from wix-private/crm-automations-client#14563 (e87197249e). Fixes the three create scenarios that failed the eval gate on 001245d; local skill-review: blocking findings fixed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… the values in the title; percentage example (2/6) Re-exported from wix-private/crm-automations-client#14563 (31aca84037). Judges graded truncated trace previews as the final answer; local skill-review: no blocking findings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…rs[], never invented (2/6) Re-exported from wix-private/crm-automations-client#14563 (2efb1a226f). Local skill-review: no blocking findings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…r-chosen ids, encoded literals and abbreviated read-backs as expected (2/6) Re-exported from wix-private/crm-automations-client#14563 (d5f557ecb9). Local skill-review: no blocking findings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…in judges name the catalog filter id (2/6) Re-exported from wix-private/crm-automations-client#14563 (8e746de0ef). Local skill-review: no blocking findings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Brings the branch up to date with main; the exported automations skill is unchanged (same source as wix-private/crm-automations-client#14563 at 8e746de0ef). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…t labels to the user (2/6) Re-exported from wix-private/crm-automations-client#14563 (0e8819b61b): answers the skill-review advisory on actions.md. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Brings the branch up to date with main; the exported automations skill is unchanged (same source as wix-private/crm-automations-client#14563 at 0e8819b61b). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Brings the branch up to date with main; the exported automations skill is unchanged (same source as wix-private/crm-automations-client#14563 at 0e8819b61b). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Re-exported from wix-private/crm-automations-client#14563 (0e8819b61b) and stacked on the updated stage 2 branch, which now includes main. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ge 3 (3/6) Re-exported from wix-private/crm-automations-client#14563 (0e8819b61b) onto main, which now contains stage 2 (#1648). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Brings the branch up to date with main; stage 3 content unchanged (wix-private/crm-automations-client#14563 at 0e8819b61b). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…chedules, no email work in this part (3/6) Re-exported from wix-private/crm-automations-client#14563 (abc4036c2a), after a local skill-review round (8/10, no blocking findings). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…e judges, 8 scenarios deferred (3/6) The eval sites have no create-task action, so scenarios add a Show in Inbox note instead; judges no longer need response bodies EvalForge omits; 8 scenarios move to part 4 to fit the gate's time budget. Re-exported from wix-private/crm-automations-client#14563 (298aed410f). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Migrated to https://github.com/wix-private/ax-skills/pull/57 following the move to wix-private/ax-skills. Closing this mirror PR to release the EvalForge scenario locks. The replacement preserves stack order and includes the latest canonical source updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3/4 of the Automations skill publication. Conditions, delays/variables/branches, schemas/scheduling and validation.
Each PR adds exactly four reference Markdown files relative to its immediate predecessor, satisfying the current four-file gate. Documentation YAML, index entries and applicable evals are included. The stack progressively exposes 4/8/12/16 guides and 3/5/21/29 scenarios.
Canonical source: https://github.com/wix-private/crm-automations-client/pull/14563 (e93da2b345). The exporter records the publication stage and preserves it during later syncs. Earlier stages defer entire scenarios until their required guides exist; outcome, quality and persistence assertions are unchanged. Future article links use an explicit unpublished-guide notice and the official API reference until the guide arrives.
Validation: 16 exporter tests passed; this stage has 21 scenarios validated against the repository schema, all registered articles covered, matching frontmatter/index, valid internal article links, and a successful live docs-category check. These checks are structural, not live agent evaluation results.
Merge order: part 1 → part 2 → part 3 → part 4 (original PR #1621). All four parts are ready for review and linked with GitHub’s native stack feature; each retains its predecessor as its base. Merge bottom-up. GitHub’s native stack feature can cascade ancestry/base updates; verify each layer still adds only four new reference Markdown files and inspect actual current-head evaluations before merging. No automatic merge.
The full stack preserves all original 27 scenarios and adds read-only catalog discovery and inactive-status cases. Existing Item Selection external-binding review findings remain unresolved; splitting does not establish API access or live success.
Stack: 1: discovery/lifecycle → 2: graphs/mappings → 3: conditions/timing → 4: providers/email.