Skip to content

feat(automations): providers and email actions (4/6) - #1621

Closed
yehonatanpeleg wants to merge 55 commits into
codex/automations-skills-3-conditionsfrom
codex/sync-automations-builder-skill
Closed

yehonatanpeleg wants to merge 55 commits into
codex/automations-skills-3-conditionsfrom
codex/sync-automations-builder-skill

Conversation

@yehonatanpeleg

@yehonatanpeleg yehonatanpeleg commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Part 4/4 of the Automations skill publication. Planning limits, entity/provider configuration, Item Selection and email actions.

Each PR adds exactly four reference Markdown files relative to its immediate predecessor, satisfying the current four-file gate. Documentation YAML, index entries and applicable evals are included. The stack progressively exposes 4/8/12/16 guides and 3/5/21/29 scenarios.

Canonical source: https://github.com/wix-private/crm-automations-client/pull/14563 (e93da2b345). The exporter records the publication stage and preserves it during later syncs. Earlier stages defer entire scenarios until their required guides exist; outcome, quality and persistence assertions are unchanged. Future article links use an explicit unpublished-guide notice and the official API reference until the guide arrives.

Validation: 16 exporter tests passed; this stage has 29 scenarios validated against the repository schema, all registered articles covered, matching frontmatter/index, valid internal article links, and a successful live docs-category check. These checks are structural, not live agent evaluation results.

Merge order: part 1 → part 2 → part 3 → part 4 (original PR #1621). All four parts are ready for review and linked with GitHub’s native stack feature; each retains its predecessor as its base. Merge bottom-up. GitHub’s native stack feature can cascade ancestry/base updates; verify each layer still adds only four new reference Markdown files and inspect actual current-head evaluations before merging. No automatic merge.

The full stack preserves all original 27 scenarios and adds read-only catalog discovery and inactive-status cases. Existing Item Selection external-binding review findings remain unresolved; splitting does not establish API access or live success.

Stack: 1: discovery/lifecycle → 2: graphs/mappings → 3: conditions/timing → 4: providers/email.

@yehonatanpeleg
yehonatanpeleg requested a review from a team as a code owner October 6, 2026 10:57
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

❌ EvalForge YAML Gate: Scenario Locked by Another PR

These scenarios are draft-tagged for other PRs. Wait for those PRs to merge/close, or coordinate with their authors:

@yehonatanpeleg

This comment has been minimized.

@yehonatanpeleg

Copy link
Copy Markdown
Contributor Author

#review

@github-actions

This comment has been minimized.

@yehonatanpeleg

This comment has been minimized.

@github-actions

This comment has been minimized.

@yehonatanpeleg

This comment has been minimized.

@github-actions

This comment has been minimized.

@yehonatanpeleg

This comment has been minimized.

@github-actions

This comment has been minimized.

@yehonatanpeleg

This comment has been minimized.

@github-actions

This comment has been minimized.

@yehonatanpeleg

This comment has been minimized.

1 similar comment
@yehonatanpeleg

This comment has been minimized.

@github-actions

This comment has been minimized.

@yehonatanpeleg

Copy link
Copy Markdown
Contributor Author

#rebuild

@yehonatanpeleg

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@yehonatanpeleg

This comment has been minimized.

@github-actions

This comment has been minimized.

@yehonatanpeleg

This comment has been minimized.

@github-actions

This comment has been minimized.

@yehonatanpeleg

This comment has been minimized.

@github-actions

This comment has been minimized.

@yehonatanpeleg

This comment has been minimized.

@github-actions

This comment has been minimized.

@yehonatanpeleg

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Skill Review

✅ Review job completed · triggered by @github-actions[bot]

Score: 8/10 · 5f55c4b · 19 files

A solid, internally consistent stage-4 publication of the Automations email/entity/feasibility skills with good eval coverage across six new scenarios; the only notable issues are redundant procedural detail duplicated between actions.md §5.1 and the new Automations Email Actions skill, and an unverifiable hardcoded owner-role-id constant.

2 advisory

skills/wix-manage/references/automations/actions.md

  • 🟡 advisory — line 70 · orchestration-and-worked-examples

    Check the provider APIs registry (Automations Entity and Provider Configuration §3) before treating an opaque widget as unavailable. Send an email has a dedicated Generate Action Input Mapping API: ...

    The §5.1 block in actions.md re-states, in its own words, nearly the whole initialize/persist/branch-duplication/recipient-check/rollout-failure procedure that email-actions.md already owns in full (its §§1-2). A future correction to one copy (e.g. the branch-duplication rule or the rollout-failure wording) can land in only one file, leaving the other to quietly drift and give an agent that reads only actions.md a stale version of the rule.

    Instead: Trim actions.md §5.1 to orchestration-level guidance ("check the provider APIs registry; email has a dedicated initializer — see Automations Email Actions for the call, settings and persistence sequence") and let email-actions.md stay the single place that spells out the step-by-step procedure, fabrication warnings and rollout-failure handling.

skills/wix-manage/references/automations/email-actions.md

  • 🟡 advisory — line 513

    (6601492336091027458 = the site-owner role. It is a fixed Wix role id, not a per-site value: Wix's own owner-addressed email templates use it on every site. If an existing owner-addressed email step on the same site uses a different owner role id, copy that one instead.)

    This is the one place in the skill where a wrong or stale magic constant would silently misroute every 'send to the site owner' email the skill builds, and the claim can't be checked from the text alone — if the id is wrong on some sites, the fallback (copy an existing step's role id) only helps when such a step already exists.

    Instead: Confirm this id against a live site (per CONTRIBUTING.md#verify-the-api-details) before merge, or note explicitly that the constant should be cross-checked against Query Roles / the site's existing owner-addressed templates before use rather than assumed universal.

Comment /review to review the current commit again.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

⏳ Awaiting skill review — commit 43f648a

The review runs automatically when a PR is opened, and on request after that.

Comment /review to review this commit.

@yehonatanpeleg yehonatanpeleg changed the title feat(automations): providers and email actions (4/5) feat(automations): providers and email actions (4/6) Oct 8, 2026
yehonatanpeleg and others added 4 commits October 8, 2026 16:14
Re-exported from wix-private/crm-automations-client#14563 (0e8819b61b) and stacked on the updated stage 3 branch, which now includes main.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@yehonatanpeleg

Copy link
Copy Markdown
Contributor Author

Migrated to https://github.com/wix-private/ax-skills/pull/58 following the move to wix-private/ax-skills. Closing this mirror PR to release the EvalForge scenario locks. The replacement preserves stack order and includes the latest canonical source updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant