-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation in printable format (CSS media queries) #2754
Conversation
…umentation files from single files.
@EugeneHlushko , @montogeek : Want to approve? /ref: #2632 |
Hi @SetTrend, we probably want to get |
Also i think we dont want to commit the aggregated files, rather build them before deploy |
Yes files are important, but they can be generated on the fly before deployment from the fresh revision. We dont need to commit and ignore them. UPD: The url for print is a must have when we merge this functionality 👍 |
Ah, sure, I now understand. So, you just don't want to have the "artifacts" stored in the repository. That's a great idea. I can easily remove the files from my branch. However, I'm not too familiar with the WebPack build process. So, how would you suggest to go forward to have these available as HTML after build? |
I think what you did works well, its just the matter of when we generate the As we have changed the build setup in Meanwhile i suggest to remove the generated |
… being checked in.
…s.org into printable-doc
…umentation files from single files.
… being checked in.
…s.org into printable-doc
addCache test correctly _describe your changes..._ - [ ] Read and sign the [CLA][1]. PRs that haven't signed it won't be accepted. - [ ] Make sure your PR complies with the [writer's guide][2]. - [ ] Review the diff carefully as sometimes this can reveal issues. - __Remove these instructions from your PR as they are for your eyes only.__ [1]: https://cla.js.foundation/webpack/webpack.js.org [2]: https://webpack.js.org/writers-guide/
* docs(config) document optimization.chunkIds * docs(config) optimization.chunkIds defaults, format strings
…umentation files from single files.
… being checked in.
I now removed the I started a discussion at StackOverflow. If I won't get a remedy there, I'm going to delete my branch and re-create it. Do you perhaps have an idea what I can do to get my branch to only show the two commits originating from myself? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats indeed weird but i don't seem to scratch an idea on top of my head for why it looks like this after merging master into it...
Good job on removing the stuff tho now it looks much better in the diff 👍
Today, I edited the I'm very sorry for the long delay. I'm doing this in my spare time and was busy with other projects. Plus, I needed to learn more about git in order to accomplish the clean-up. Cheers, /refs: |
For some reason this branch holds additional commit diff with master, lets have a look at it when we have reference: #2039 |
Hi @SetTrend I'm happy to confirm that |
I have now created a whole new fork and, after pulling the latest webpack.js.org From what I can see, the HTML structure of the docs have changed. I need to apply header,
nav,
footer,
.notification-bar,
.page-links,
.gitter
{
@media print {
display: none !important;
}} (... plus a new one for the Contributors section). From what I can see, server.jsx is the page root file. Where would you want me to put SCSS for that file (i.e. |
I would suggest |
Synopsis
With this PR implemented, documentation becomes printable; i.e. without navigation, comment and other chrome.
Steps done
.interactive
sections get hidden for printing.contributors
section gets hidden for printing..footer
gets hidden for printing..page-links
section gets hidden for printing.NodeJS
script that recursively concatenates all MarkDown files within a folder into large "chapter" files. The new, automatically generated files match the regular expression: "(_\w+)?_all.md
".Further Information
At this time I have no clue on how to present the generated "
*_all.md
" files to the user. Perhaps you've got an idea?