Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(printable) cherry-pick SetTrends work and resolve confclicts #3093

Merged
merged 17 commits into from
Jun 6, 2019

Conversation

EugeneHlushko
Copy link
Member

@EugeneHlushko EugeneHlushko commented Jun 3, 2019

Fixes #2632

Based on @SetTrend 's initial work in #2754
Cherry-picked to not lose contribution.

Changes:

  • Hand drawn icon of the printer to not have issues with copyrights
  • Adding an ability to print current page
  • Adding ability to print current section in the new tab, which automatically closes when cancelled/printed dialog closed
  • Made it possible to not include the concatenated pages into FE bundle to not increase bundle size
  • Made service worker ignore the printable URLs as it would serve 404 from FE bundles
  • Made service worker to go network-first for less problems with caching when your device is online
  • Refactored scss to not have importants
  • Added respective components to support the feature

Screen Shot 2019-06-05 at 4 39 07 PM

@netlify
Copy link

netlify bot commented Jun 3, 2019

Preview is ready

Built with commit 4238795

https://deploy-preview-3093--webpackjsorg-netlify.netlify.com

@EugeneHlushko EugeneHlushko marked this pull request as ready for review June 5, 2019 13:32
@EugeneHlushko EugeneHlushko requested a review from montogeek June 5, 2019 13:33
@EugeneHlushko
Copy link
Member Author

EugeneHlushko commented Jun 6, 2019

Ideas why this fails on travis are welcome:

✖ FAIL load https://david-dm.org/webpack-contrib/url-loader.svg
  | operator: load
  | expected: 200 https://david-dm.org/webpack-contrib/url-loader.svg
  |   actual: ETIMEDOUT
  |       at: dist/loaders/url-loader/index.html:3:69 <img src="https://david-dm.org/webpack-contrib/url-loader.svg" alt="deps">

The image is in place on FE as well: https://deploy-preview-3093--webpackjsorg-netlify.netlify.com/loaders/url-loader

@montogeek
Copy link
Member

It says there: ETIMEDOUT, Maybe increase it?

@EugeneHlushko
Copy link
Member Author

There is no API for it in the package, CC @Munter maybe you want to add this later

@EugeneHlushko
Copy link
Member Author

Another one randomly failed :) FAIL load https://david-dm.org/webpack-contrib/css-loader.svg

@EugeneHlushko
Copy link
Member Author

Could be that travis cannot handle 25 concurrents well enough. Just lowered to 8

@EugeneHlushko
Copy link
Member Author

We might want to discuss disabling the checks for downloaded pages? @montogeek

@EugeneHlushko
Copy link
Member Author

Okay that worked, will remove the exception and its good to go

@EugeneHlushko
Copy link
Member Author

Going to merge when build passes and make a short intro in twitter :)

@EugeneHlushko EugeneHlushko merged commit f484686 into master Jun 6, 2019
@EugeneHlushko EugeneHlushko deleted the printable branch June 6, 2019 17:15
@EugeneHlushko
Copy link
Member Author

TY @SetTrend , myself and people who supported this feature

@SetTrend
Copy link
Contributor

SetTrend commented Jun 6, 2019

@EugeneHlushko : Thanks so much, Eugene. That's such an excellent work you did. I love it!! ❤️ 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation in printable format (CSS media queries)
3 participants