-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(printable) cherry-pick SetTrends work and resolve confclicts #3093
Conversation
Preview is ready Built with commit 4238795 https://deploy-preview-3093--webpackjsorg-netlify.netlify.com |
…stantly. Stop including bundle files on that page.
Ideas why this fails on travis are welcome:
The image is in place on FE as well: https://deploy-preview-3093--webpackjsorg-netlify.netlify.com/loaders/url-loader |
It says there: ETIMEDOUT, Maybe increase it? |
There is no API for it in the package, CC @Munter maybe you want to add this later |
Another one randomly failed :) |
Could be that travis cannot handle 25 concurrents well enough. Just lowered to 8 |
We might want to discuss disabling the checks for downloaded pages? @montogeek |
Okay that worked, will remove the exception and its good to go |
Going to merge when build passes and make a short intro in twitter :) |
TY @SetTrend , myself and people who supported this feature |
@EugeneHlushko : Thanks so much, Eugene. That's such an excellent work you did. I love it!! ❤️ 👍 |
Fixes #2632
Based on @SetTrend 's initial work in #2754
Cherry-picked to not lose contribution.
Changes: