Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention defaults in config example #1896

Closed
wants to merge 2 commits into from
Closed

mention defaults in config example #1896

wants to merge 2 commits into from

Conversation

pravdomil
Copy link
Contributor

@pravdomil pravdomil commented Mar 8, 2018

see diff

@jsf-clabot
Copy link

jsf-clabot commented Mar 8, 2018

CLA assistant check
All committers have signed the CLA.

@montogeek
Copy link
Member

Correct default is src/index.js. Could you please update it? Thanks!

@pravdomil
Copy link
Contributor Author

@montogeek
Copy link
Member

Yes, you are right. Also, could you please change base branch to next? It is used to track all webpack 4 changes

@pravdomil
Copy link
Contributor Author

pravdomil commented Mar 9, 2018

@montogeek @webpack it's not next, version 4 is released so I'm merging it to master, and guys in webpack do not release new version if you don't update the documentation, that's totally irresponsible in my opinion, if you access webpack.js.org that docs is marked to be for version 4 and it's not.

and you mark it has enhancement? I cannot found the new default values anywhere, so please update the docs as soon as possible, otherwise version 4 is really nice!

@montogeek
Copy link
Member

This is a different repo from webpack, next is used to track all webpack 4 changes (#1856 ), once everything is ready it will be merged to master.

That bagde in the website refers to the latest version available, not the version of the documentation.

@pravdomil
Copy link
Contributor Author

well that should be changed, it's misleading if that's not a version of documentation so what is? look at the screenshot, everybody will think that that's a documentation for version 4

screen

@montogeek
Copy link
Member

Yes, definitely, we already talked about it in #1854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants