Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show version of webpack.js.org not webpack in sidebar #1901

Closed
wants to merge 4 commits into from
Closed

Show version of webpack.js.org not webpack in sidebar #1901

wants to merge 4 commits into from

Conversation

pravdomil
Copy link
Contributor

#1854 #1896

actual
screen

dhruvdutt
dhruvdutt reviewed Mar 15, 2018
View reviewed changes
Copy link
Member

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting. We should keep it to 3.x or the latest version of webpack 3.

@pravdomil
Copy link
Contributor Author

Fell free to change it package.json

@pravdomil pravdomil closed this Mar 16, 2018
@pravdomil pravdomil reopened this Mar 16, 2018
@jeremenichelli
Copy link
Member

We are actually considering on removing that badge at all since it's really confusing for users. Thanks for rising this, but I think we are gonna remove it at all for sure and see if we can indicate the webapck package version somehwere else in the UI. I don't see the value of showing the verison of the site itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvdutt dhruvdutt dhruvdutt left review comments

Assignees
No one assigned
Labels
Site Structure UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pravdomil @jeremenichelli @dhruvdutt @montogeek