Skip to content

feat(parameters): implement parameters logic via reduce #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 3 commits into from
Jun 6, 2026
Merged

feat(parameters): implement parameters logic via reduce #118

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca6f5da
feat(parameters): implement parameters logic via reduce
moshams272 Jun 2, 2026
6d0425b
Enhance the code with `for` loop instead of `reduce`
moshams272 Jun 5, 2026
37a5f71
Merge branch 'main' into feat/signature-syntax
moshams272 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 23 additions & 15 deletions plugins/shared/titles.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,21 +63,29 @@ export const fullName = model => {
return `${root.name}.${name}`;
};

export const formatParams = (params = []) =>
params
.map(({ name, flags }, i) => {
const paramName = flags?.isRest ? `...${name}` : name;
if (flags?.isRest) return i ? `, ${paramName}` : paramName;

return flags?.isOptional
? i
? `[, ${paramName}]`
: `[${paramName}]`
: i
? `, ${paramName}`
: paramName;
})
.join('');
export const formatParams = (params = []) => {
let result = '';
let openBrackets = 0;

for (let i = 0; i < params.length; i++) {
const { name, flags } = params[i];
const isRest = flags?.isRest ?? false;
const paramName = isRest ? `...${name}` : name;

if (isRest || flags?.isOptional) {
result += (i ? '[, ' : '[') + paramName;
openBrackets++;
} else {
if (openBrackets) {
result += ']'.repeat(openBrackets);
openBrackets = 0;
}
result += (i ? ', ' : '') + paramName;
}
}

return result + ']'.repeat(openBrackets);
};
Comment thread
moshams272 marked this conversation as resolved.

export const signatureExpression = (
model,
Expand Down