feat(parameters): implement parameters logic via reduce - #118
Merged
Conversation
Refactors formatParams to use reduce() instead of map(), enabling nested optional and rest parameter syntax as per doc-kit specification.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Can you have a before/after of what the output looks like? |
Member
Author
Actually, the UI remains with no visual diff. The difference lies in the generated Markdown files. Here is the MD: I followed the And if doc-kit update something, it will not fail in webpack-doc-kit as we follow their instructions. |
avivkeller
reviewed
Jun 4, 2026
Co-authored-by: Aviv Keller <me@aviv.sh>
avivkeller
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Refactors
formatParamsto useforloop instead ofmap(), enabling nested optional and rest parameter syntax as per doc-kit specification.