Skip to content

feat(parameters): implement parameters logic via reduce - #118

Merged
avivkeller merged 3 commits into
webpack:mainfrom
moshams272:feat/signature-syntax
Jun 6, 2026
Merged

feat(parameters): implement parameters logic via reduce#118
avivkeller merged 3 commits into
webpack:mainfrom
moshams272:feat/signature-syntax

Conversation

@moshams272

@moshams272 moshams272 commented Jun 2, 2026

Copy link
Copy Markdown
Member

Refactors formatParams to use for loop instead of map(), enabling nested optional and rest parameter syntax as per doc-kit specification.

Refactors formatParams to use reduce() instead of map(), enabling nested optional and rest parameter syntax as per doc-kit specification.
@vercel

vercel Bot commented Jun 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview, Comment Jun 5, 2026 11:26am

Request Review

@avivkeller

Copy link
Copy Markdown
Member

Can you have a before/after of what the output looks like?

@moshams272

Copy link
Copy Markdown
Member Author

Can you have a before/after of what the output looks like?

Actually, the UI remains with no visual diff. The difference lies in the generated Markdown files.

Here is the MD:

Before:
Screenshot from 2026-06-03 19-40-31

After:
Screenshot from 2026-06-03 22-00-38

I followed the doc-kit specification to use nested brackets. Even the UI yields the same result either way, this PR ensures the Generator outputs strictly aligned with doc-kit specification, instead of relying on the parser's error recovery in that file in node.js/doc-kit.

And if doc-kit update something, it will not fail in webpack-doc-kit as we follow their instructions.

Comment thread plugins/shared/titles.mjs
Co-authored-by: Aviv Keller <me@aviv.sh>
@avivkeller
avivkeller merged commit 7f04db6 into webpack:main Jun 6, 2026
4 checks passed
@moshams272
moshams272 deleted the feat/signature-syntax branch June 6, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants