Repository navigation
Conversation
WGSL does not allow attributes on else-if or else branches. Drop the WESL-only attributes fields from ElseIfClause and ElseClause, stop printing them, and treat these nodes like IfClause for SyntaxNode.
|
Welcome, new contributor! Please make sure you have read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
BenjaminBrienen
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WGSL does not allow attributes on
else iforelsebranches. This removes theattributesfields fromElseIfClauseandElseClausein the syntax tree, stops printing them, and updates theweslvisitor and query macros to match. The grammar was already not attaching them.Adds the
if_statement_else_clauses_have_no_attributestest inwgsl-parse.cargo fmt,cargo clippy -p wgsl-parse -p wesl --all-targets -- -D warningsandcargo test -p wgsl-parse -p weslall pass.Closes #331