Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP: 0x00 in a header value #21019

Merged
merged 2 commits into from
Jan 3, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions fetch/h1-parsing/resources-with-0x00-in-header.window.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
async_test(t => {
const script = document.createElement("script");
t.add_cleanup(() => script.remove());
script.src = "resources/script-with-0x00-in-header.py";
script.onerror = t.step_func_done();
script.onload = t.unreached_func();
document.body.append(script);
}, "Expect network error for script with 0x00 in a header");

async_test(t => {
const frame = document.createElement("iframe");
t.add_cleanup(() => frame.remove());
frame.src = "resources/document-with-0x00-in-header.py";
// If network errors result in load events for frames per
// https://github.com/whatwg/html/issues/125 and https://github.com/whatwg/html/issues/1230 this
// should be changed to use the load event instead.
t.step_timeout(() => {
assert_equals(frame.contentDocument, null);
t.done();
}, 1000);
document.body.append(frame);
}, "Expect network error for frame navigation to resource with 0x00 in a header");

async_test(t => {
const img = document.createElement("img");
t.add_cleanup(() => img.remove());
img.src = "resources//blue-with-0x00-in-a-header.asis";
Copy link
Contributor

@rwlbuis rwlbuis Jan 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double '/' usage.

img.onerror = t.step_func_done();
img.onload = t.unreached_func();
document.body.append(img);
}, "Expect network error for image with 0x00 in a header");
6 changes: 6 additions & 0 deletions fetch/h1-parsing/resources/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
`blue-with-0x00-in-a-header.asis` is a copy from `../../images/blue.png` with the following prepended using Control Pictures to signify actual newlines and 0x00:
```
HTTP/1.1 200 AN IMAGE␍␊
Content-Type: image/png␍␊
Custom: ␀␍␊␍␊
```
Binary file not shown.
4 changes: 4 additions & 0 deletions fetch/h1-parsing/resources/document-with-0x00-in-header.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
def main(request, response):
response.headers.set("Content-Type", "text/html")
response.headers.set("Custom", "\0")
return "<!doctype html><b>This is irrelevant.</b>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe could do a text like "This is a simple document." or something generic.

4 changes: 4 additions & 0 deletions fetch/h1-parsing/resources/script-with-0x00-in-header.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
def main(request, response):
response.headers.set("Content-Type", "text/javascript")
response.headers.set("Custom", "\0")
return "var irrelevant = 0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.