-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP: 0x00 in a header value #21019
Merged
Merged
HTTP: 0x00 in a header value #21019
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
async_test(t => { | ||
const script = document.createElement("script"); | ||
t.add_cleanup(() => script.remove()); | ||
script.src = "resources/script-with-0x00-in-header.py"; | ||
script.onerror = t.step_func_done(); | ||
script.onload = t.unreached_func(); | ||
document.body.append(script); | ||
}, "Expect network error for script with 0x00 in a header"); | ||
|
||
async_test(t => { | ||
const frame = document.createElement("iframe"); | ||
t.add_cleanup(() => frame.remove()); | ||
frame.src = "resources/document-with-0x00-in-header.py"; | ||
// If network errors result in load events for frames per | ||
// https://github.com/whatwg/html/issues/125 and https://github.com/whatwg/html/issues/1230 this | ||
// should be changed to use the load event instead. | ||
t.step_timeout(() => { | ||
assert_equals(frame.contentDocument, null); | ||
t.done(); | ||
}, 1000); | ||
document.body.append(frame); | ||
}, "Expect network error for frame navigation to resource with 0x00 in a header"); | ||
|
||
async_test(t => { | ||
const img = document.createElement("img"); | ||
t.add_cleanup(() => img.remove()); | ||
img.src = "resources//blue-with-0x00-in-a-header.asis"; | ||
img.onerror = t.step_func_done(); | ||
img.onload = t.unreached_func(); | ||
document.body.append(img); | ||
}, "Expect network error for image with 0x00 in a header"); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
`blue-with-0x00-in-a-header.asis` is a copy from `../../images/blue.png` with the following prepended using Control Pictures to signify actual newlines and 0x00: | ||
``` | ||
HTTP/1.1 200 AN IMAGE␍␊ | ||
Content-Type: image/png␍␊ | ||
Custom: ␀␍␊␍␊ | ||
``` |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
def main(request, response): | ||
response.headers.set("Content-Type", "text/html") | ||
response.headers.set("Custom", "\0") | ||
return "<!doctype html><b>This is irrelevant.</b>" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe could do a text like "This is a simple document." or something generic. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
def main(request, response): | ||
response.headers.set("Content-Type", "text/javascript") | ||
response.headers.set("Custom", "\0") | ||
return "var irrelevant = 0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double '/' usage.