Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP: 0x00 in a header value #21019

Merged
merged 2 commits into from
Jan 3, 2020
Merged

HTTP: 0x00 in a header value #21019

merged 2 commits into from
Jan 3, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 3, 2020

Tests to complement those written in #10424.

@annevk
HTTP: 0x00 in a header value
d2da820 
Tests to complement those written in #10424.
@annevk annevk requested a review from rwlbuis January 3, 2020 10:18
rwlbuis
rwlbuis reviewed Jan 3, 2020
View reviewed changes
fetch/h1-parsing/resources-with-0x00-in-header.window.js Outdated
async_test(t => {
const img = document.createElement("img");
t.add_cleanup(() => img.remove());
img.src = "resources//blue-with-0x00-in-a-header.asis";
Copy link
Contributor

@rwlbuis rwlbuis Jan 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double '/' usage.

rwlbuis
rwlbuis reviewed Jan 3, 2020
View reviewed changes
fetch/h1-parsing/resources/document-with-0x00-in-header.py Outdated
def main(request, response):
response.headers.set("Content-Type", "text/html")
response.headers.set("Custom", "\0")
return "<!doctype html><b>This is irrelevant.</b>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe could do a text like "This is a simple document." or something generic.

rwlbuis
rwlbuis reviewed Jan 3, 2020
View reviewed changes
fetch/h1-parsing/resources/script-with-0x00-in-header.py Outdated
def main(request, response):
response.headers.set("Content-Type", "text/javascript")
response.headers.set("Custom", "\0")
return "var irrelevant = 0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

rwlbuis
rwlbuis approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@rwlbuis rwlbuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comments.

@rwlbuis
Copy link
Contributor

rwlbuis commented Jan 3, 2020

BTW it seems there are lint errors:
./wpt lint --all
ERROR:lint:fetch/h1-parsing/resources/blue-with-0x00-in-a-header.asis:1: Test-file line ends with CR (U+000D) character (CR AT EOL)
ERROR:lint:fetch/h1-parsing/resources/blue-with-0x00-in-a-header.asis:2: Test-file line ends with CR (U+000D) character (CR AT EOL)
ERROR:lint:fetch/h1-parsing/resources/blue-with-0x00-in-a-header.asis:3: Test-file line ends with CR (U+000D) character (CR AT EOL)
ERROR:lint:fetch/h1-parsing/resources/blue-with-0x00-in-a-header.asis:4: Test-file line ends with CR (U+000D) character (CR AT EOL)
ERROR:lint:fetch/h1-parsing/resources/blue-with-0x00-in-a-header.asis:5: Test-file line ends with CR (U+000D) character (CR AT EOL)

@wpt-pr-bot wpt-pr-bot requested a review from jgraham January 3, 2020 16:01
@annevk annevk merged commit 38ecde8 into master Jan 3, 2020
@annevk annevk deleted the annevk/http-0x00 branch January 3, 2020 16:12
@annevk annevk mentioned this pull request Aug 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwlbuis rwlbuis rwlbuis approved these changes

@domfarolino domfarolino Awaiting requested review from domfarolino

@jdm jdm Awaiting requested review from jdm

@mnot mnot Awaiting requested review from mnot

@youennf youennf Awaiting requested review from youennf

@yutakahirano yutakahirano Awaiting requested review from yutakahirano

@jgraham jgraham Awaiting requested review from jgraham

Assignees

@domfarolino domfarolino

Labels
fetch infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@annevk @rwlbuis @domfarolino @wpt-pr-bot @moz-wptsync-bot