Adds the web install feature #3488
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,3 @@ | ||||||||
| name: web-install | ||||||||
| description: "The `navigator.install` API allows an origin to request an application installation on a user's device." | ||||||||
|
Collaborator
There was a problem hiding this comment. We have a bunch of guidelines for these descriptions. The short version here is that I'm suggesting to make this more direct (avoiding "allows" and "origin") and to mention PWAs to help this come up when searched for related features. I'm not saying it has to be exactly this, but something along these lines would be more consistent with other features:
Suggested change
|
||||||||
| spec: https://github.com/w3c/manifest/pull/1175 | ||||||||
|
Collaborator
There was a problem hiding this comment. This needs an exception in the
Collaborator
There was a problem hiding this comment. Oh one more thing:
Suggested change
|
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Generated from: web-install.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| status: | ||
| baseline: false | ||
| support: {} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm skeptical "web install" will become a well-known name for this. I think we should use the interface itself:
I'd suggest renaming the file to line up with this (
navigator-install.ymlor justinstall.yml).