Skip to content

Conversation

@diekus
Copy link
Contributor

@diekus diekus commented Oct 27, 2025

Adds the We Install feature id web-install

Adds the We Install feature id `web-install`
@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 27, 2025
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this! This ought to fix #3467. Some suggestions for you in line comments.

@@ -0,0 +1,3 @@
name: web-install
description: "The `navigator.install` API allows an origin to request an application installation on a user's device."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a bunch of guidelines for these descriptions. The short version here is that I'm suggesting to make this more direct (avoiding "allows" and "origin") and to mention PWAs to help this come up when searched for related features. I'm not saying it has to be exactly this, but something along these lines would be more consistent with other features:

Suggested change
description: "The `navigator.install` API allows an origin to request an application installation on a user's device."
description: The `navigator.install()` method triggers a request to install a progressive web app.

@@ -0,0 +1,3 @@
name: web-install
description: "The `navigator.install` API allows an origin to request an application installation on a user's device."
spec: https://github.com/w3c/manifest/pull/1175
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an exception in the defaultAllowlist in scripts/spec.ts, so the tests pass. (There's a bug for this: #3470.)

@@ -0,0 +1,3 @@
name: web-install
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm skeptical "web install" will become a well-known name for this. I think we should use the interface itself:

Suggested change
name: web-install
name: navigator.install()

I'd suggest renaming the file to line up with this (navigator-install.yml or just install.yml).

@@ -0,0 +1,3 @@
name: web-install
description: "The `navigator.install` API allows an origin to request an application installation on a user's device."
spec: https://github.com/w3c/manifest/pull/1175
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh one more thing:

Suggested change
spec: https://github.com/w3c/manifest/pull/1175
group: progressive-web-app
spec: https://github.com/w3c/manifest/pull/1175

@ddbeck ddbeck added the early features Feature definition work for features without shipping implementations label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

early features Feature definition work for features without shipping implementations feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants