Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/lib/tool_schema/ruby_llm_builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def self.scalar_symbol(type)
case type
when :string then :string
when :integer then :integer
when :float then :float
when :float then :number # RubyLLM uses `number` not `float`
when :boolean then :boolean
else :any
end
Expand All @@ -71,7 +71,7 @@ def self.scalar_symbol(type)
def self.scalar_method(type)
case type
when :integer then :integer
when :float then :float
when :float then :number # RubyLLM uses `number` not `float`
when :boolean then :boolean
else :string
end
Expand Down
35 changes: 35 additions & 0 deletions test/tool_schema_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,41 @@ def test_fast_mcp_builder_handles_boolean
end
end

def test_ruby_llm_builder_handles_float_type
params_ast = [
{
name: :progress,
required: false,
type: :float,
description: 'Progress percentage'
}
]

params_proc = ToolSchema::RubyLlmBuilder.params_block(params_ast)

# This should not raise "undefined method 'float'" error
# RubyLLM uses `number` not `float`
tool_class = Class.new(RubyLLM::Tool) do
params(&params_proc)
end

schema = tool_class.new.params_schema
progress_prop = schema['properties']['progress']

assert_equal 'number', progress_prop['type']
end

def test_ruby_llm_builder_float_type_methods
# Verify scalar_method and scalar_symbol return :number for :float
assert_equal :number, ToolSchema::RubyLlmBuilder.scalar_method(:float)
assert_equal :number, ToolSchema::RubyLlmBuilder.scalar_symbol(:float)

# Other types should remain unchanged
assert_equal :integer, ToolSchema::RubyLlmBuilder.scalar_method(:integer)
assert_equal :boolean, ToolSchema::RubyLlmBuilder.scalar_method(:boolean)
assert_equal :string, ToolSchema::RubyLlmBuilder.scalar_method(:string)
end

private

def build_echo_service
Expand Down