fix: map float type to number in RubyLlmBuilder#16
Merged
Conversation
RubyLLM's params DSL uses `number` method, not `float`. This was causing 'undefined method float' errors when converting tools with Float parameters (e.g., progress percentage). - scalar_method(:float) now returns :number - scalar_symbol(:float) now returns :number - Added tests for float type handling
Member
Author
Evidence: RubyLLM uses
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AI agents using tools with Float parameters (like
progressincreative_create_service) fail with:Root Cause
RubyLlmBuildermaps:floattype to:float, but RubyLLM's params DSL only hasnumbermethod, notfloat.Solution
scalar_method(:float)now returns:numberscalar_symbol(:float)now returns:numberChanges
app/lib/tool_schema/ruby_llm_builder.rb: Fix float → number mappingtest/tool_schema_test.rb: Add tests for float type handlingTesting
All 23 tests pass, including 2 new tests for float type.