-
Notifications
You must be signed in to change notification settings - Fork 84
Various CI fixes #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Various CI fixes #193
Conversation
serial_lock and its dependency tree make it hard to keep tests working on Rust 1.40. In particular, all early versions of futures-util 0.3 with sufficiently low MSRV were yanked.
For some reason, the tool reports a "not found" error for these lib.rs links, but docs.rs links are fine.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
===========================================
+ Coverage 60.20% 72.93% +12.73%
===========================================
Files 16 17 +1
Lines 784 1090 +306
Branches 117 0 -117
===========================================
+ Hits 472 795 +323
- Misses 241 295 +54
+ Partials 71 0 -71
🚀 New features to boost your workflow:
|
|
This is a big help, thank you :-) Can you have a look at the windows failure, though? It seems the failure is legitimate. Or, I assume this was there for some time already and your changes only uncovered the bug? |
|
I didn't find a nice, maintainable way to have CI omit only the extended-siginfo feature only when testing on Windows. So instead I've gated the functionality of the feature behind After some more whack-a-mole with windows-specific warnings and errors, the only remaining failure is the coverage workflow, that seems to be due to repository configuration (it worked on my fork), so I can't resolve that. |
This doesn't remove the `-A` parameter in the CI workflow, that's still needed to override the blanket `-D clippy::all`. But it fixes the false positive from normal `cargo clippy` invocations.
Took a bunch of trial and error I mostly managed to preserve the existing test coverage, as I understood it. Notable exceptions: