-
Notifications
You must be signed in to change notification settings - Fork 84
Save and restore errno #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
serial_lock and its dependency tree make it hard to keep tests working on Rust 1.40. In particular, all early versions of futures-util 0.3 with sufficiently low MSRV were yanked.
For some reason, the tool reports a "not found" error for these lib.rs links, but docs.rs links are fine.
3670cea to
3e9d446
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #194 +/- ##
===========================================
+ Coverage 60.20% 73.54% +13.34%
===========================================
Files 16 17 +1
Lines 784 1119 +335
Branches 117 0 -117
===========================================
+ Hits 472 823 +351
- Misses 241 296 +55
+ Partials 71 0 -71
🚀 New features to boost your workflow:
|
|
@vorner While checking if the test I added does anything, I seem to have discovered that CI was never running on Windows to begin with because |
|
Looks nice overall :-). Let's wait for the other branch first, then.
I think that one was never supposed to run on Windows - I think that platform doesn't provide the extended information about signals and has only very minimal support for them. I'd say the best solution there is just to not enable that feature for Windows (I suspect that was actually the biggest reason why that's under a feature flag, but it's a long time since I wrote it). |
Closes #191
Based on #193 for now. I can rebase on master once CI if green if you want to merge this first.