-
Notifications
You must be signed in to change notification settings - Fork 126
try some quick options to route around things before doing full cbirrt #5389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Availability
Quality
Performance
The above data was generated by running scenes defined in the
|
| for _, s := range sol { | ||
| pm.logger.Infof(" sol %v", s) | ||
|
|
||
| if !s.checkPath { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, checkPath is false because:
- We haven't yet checked the path
- We have checked the path, but it was invalid
And here if checkPath is true, we're checking it again? But maybe with a different goal?
| mPoint := m.Pose().Point() | ||
| vec := mPoint.Sub(sPoint) | ||
|
|
||
| // Compute a perpendicular vector using cross product with a reference vector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments helped me understand a lot, thanks! I've pushed a higher level description above the triple for-loop.
No description provided.