[RSDK-12175] silence frequency warning if we use the PWMDriver default frequency #5387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
penguinland
reviewed
Oct 28, 2025
| // if the frequency wasn't set in the config we will default to whatever the driver sets as default frequency | ||
| // we silence the warning below if clamping the frequency was needed | ||
| if newConf.Frequency != nil { | ||
| s.logger.CWarnf(ctx, "servo frequency (%dHz) is above maximum (%dHz), setting to max instead", |
Member
There was a problem hiding this comment.
I dunno: if the default is above the maximum, I think we should log warnings about that.
Reconfigure() shouldn't run often; this shouldn't spam the logs. Why do you want to hide it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.