Skip to content

Clean up confusing rr-node lookup convention for x/y location of wires. #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaughnbetz opened this issue Apr 14, 2025 · 0 comments
Open
Assignees

Comments

@vaughnbetz
Copy link
Contributor

The code at https://github.com/verilog-to-routing/vtr-verilog-to-routing/blob/50901246919105b42a534cb58e622cada82be1bf/vpr/src/route/rr_graph2.cpp#L1225C79-L1225C90 swaps the x and y coordinates of CHANX wires when putting them in the rr_node_lookup data structure, and the find function similarly swaps them. This is baffling.

Proposed Behaviour

We should just put them in the lookup with their proper x,y values and the lookup function shouldn't swap them either.

Current Behaviour

It works, but the convention is bizarre, making the code less readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants