Skip to content

fix(embed): make fcntl import conditional for Windows compatibility #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

fix(embed): make fcntl import conditional for Windows compatibility #868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions hindsight-embed/hindsight_embed/profile_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@
Each profile has its own config, daemon lock, log file, and port.
"""

import fcntl
import hashlib
import json
import os
import sys

if sys.platform != "win32":
import fcntl
from dataclasses import dataclass, field
from datetime import datetime, timezone
from pathlib import Path
Expand Down Expand Up @@ -470,8 +472,9 @@ def _save_metadata(self, metadata: ProfileMetadata):
temp_file = metadata_file.with_suffix(".json.tmp")

with open(temp_file, "w") as f:
# Acquire exclusive lock
fcntl.flock(f.fileno(), fcntl.LOCK_EX)
# Acquire exclusive lock (Unix only — Windows uses atomic rename for safety)
if sys.platform != "win32":
fcntl.flock(f.fileno(), fcntl.LOCK_EX)
try:
json.dump(
{"version": metadata.version, "profiles": metadata.profiles},
Expand All @@ -481,7 +484,8 @@ def _save_metadata(self, metadata: ProfileMetadata):
f.flush()
os.fsync(f.fileno())
finally:
fcntl.flock(f.fileno(), fcntl.LOCK_UN)
if sys.platform != "win32":
fcntl.flock(f.fileno(), fcntl.LOCK_UN)

# Atomic rename
temp_file.rename(metadata_file)
Expand Down