fix(embed): make fcntl import conditional for Windows compatibility#868
Open
octo-patch wants to merge 1 commit intovectorize-io:mainfrom
Open
fix(embed): make fcntl import conditional for Windows compatibility#868octo-patch wants to merge 1 commit intovectorize-io:mainfrom
octo-patch wants to merge 1 commit intovectorize-io:mainfrom
Conversation
hindsight-embed crashes on Windows at import time because fcntl is a Unix-only stdlib module. Guard the import with a sys.platform check and skip flock() calls on Windows — the atomic rename that follows already provides sufficient safety for single-process use on Windows. Fixes vectorize-io#865
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #865
Problem
hindsight-embedcrashes immediately on Windows 11 at import time becauseprofile_manager.pyunconditionally importsfcntl, which is a Unix-only stdlib module. This blocks all Windows users from usinghindsight-embed(and the OpenClaw plugin that depends on it).Solution
Guard the
import fcntlwithif sys.platform != "win32":and wrap bothfcntl.flock()calls in the same check. The fix follows the same pattern used in#694for the Claude Code integration.On Windows, the file locking step is skipped — the atomic
rename()that follows already provides sufficient crash-safety for the single-process metadata writes in_save_metadata().Testing
ModuleNotFoundErroron Windows at startup.fcntl.flock()is still called for exclusive locking during metadata writes.