Skip to content

Add psync offset range information to the failed psync log #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2025
+7 −5
Merged

Add psync offset range information to the failed psync log #2877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/replication.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,13 +863,15 @@ int primaryTryPartialResynchronization(client *c, long long psync_offset) {
if (!server.repl_backlog || psync_offset < server.repl_backlog->offset ||
psync_offset > (server.repl_backlog->offset + server.repl_backlog->histlen)) {
serverLog(LL_NOTICE,
"Unable to partial resync with replica %s for lack of backlog (Replica request was: %lld).",
replicationGetReplicaName(c), psync_offset);
"Unable to partial resync with replica %s for lack of backlog (Replica request was %s:%lld, "
"and I can only reply with the range [%lld, %lld]).",
replicationGetReplicaName(c), primary_replid, psync_offset, server.repl_backlog->offset,
server.repl_backlog->offset + server.repl_backlog->histlen);
if (psync_offset > server.primary_repl_offset) {
serverLog(LL_WARNING,
"Warning: replica %s tried to PSYNC with an offset that is greater than the primary replication "
"offset.",
replicationGetReplicaName(c));
"Warning: replica %s tried to PSYNC with an offset (%lld) that is greater than "
"the primary replication offset (%lld)",
replicationGetReplicaName(c), psync_offset, server.primary_repl_offset);
}
goto need_full_resync;
}
Expand Down
Loading