Skip to content

Conversation

@enjoy-binbin
Copy link
Member

Although we can infer this infomartion from the replica logs,
i think this still would be useful to see this information directly
in the primary logs.

So now we can see the psync offset range when psync fails and then
we can analyze and adjust the value of repl-backlog-size.

Although we can infer this infomartion from the replica logs,
i think this still would be useful to see this information directly
in the primary logs.

So now we can see the psync offset range when psync fails and then
we can analyze and adjust the value of repl-backlog-size.

Signed-off-by: Binbin <[email protected]>
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.41%. Comparing base (9562bdc) to head (9fb5b4e).
⚠️ Report is 5 commits behind head on unstable.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #2877   +/-   ##
=========================================
  Coverage     72.41%   72.41%           
=========================================
  Files           128      128           
  Lines         70439    70439           
=========================================
  Hits          51006    51006           
  Misses        19433    19433           
Files with missing lines Coverage Δ
src/replication.c 85.82% <ø> (ø)

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@enjoy-binbin enjoy-binbin merged commit a087cc1 into valkey-io:unstable Nov 29, 2025
54 of 56 checks passed
@enjoy-binbin enjoy-binbin deleted the repl_log branch November 29, 2025 04:20
enjoy-binbin added a commit to enjoy-binbin/valkey that referenced this pull request Nov 29, 2025
This crash was introduced in valkey-io#2877, we will crash when there is
no replication backlog.

Signed-off-by: Binbin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants