Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test issues #168

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

MishkaMN
Copy link
Contributor

PR Details

Description

I tested the Humble SSC wrapper on Blue Lexus using the binaries I got form Hexagon.
This was basically a simple smoke/regression test that just lane follows on the innocation drive.
driver_shutdown_ros2 (hence assuming dirver_shutdown too) just needed to be built for it to successfully launch.
I will try to test on Fusion the ROS1 package if I have time.

NOTE: I tested with all develop images which are in Foxy except the ssc_wrapper.
Initially either the engage request was not being received or the ssc was just not responding (it did not shift gear etc after the engage service returned successfull).
This prompted me to use ros1_bridge and platform_ros2 as Humble, but that required minimum of 11.7 Cuda to work (by platform_ros2). This made me reinstall Nvidia and Kvaser drivers on the vehicle.

In the process, I also remembered to install libas-common on the host (it is there in the image), which is requirement for Humble SSC binary to work. I am guessing this made the trick, because now with the same setup, the Lexus was able to engage and drive using trajectory_follower control plugin.

Related GitHub Issue

NA

Related Jira Key

ARC-234

Motivation and Context

Humble Upgrade smoke test

How Has This Been Tested?

Innovation Drive Basic Lane Following

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN requested a review from adev4a January 30, 2025 17:18
@MishkaMN MishkaMN self-assigned this Jan 30, 2025
@MishkaMN MishkaMN added the bug Something isn't working label Jan 30, 2025
@MishkaMN MishkaMN requested a review from adev4a January 30, 2025 20:52
@MishkaMN MishkaMN merged commit 96bb369 into develop-humble Jan 30, 2025
2 of 3 checks passed
@MishkaMN MishkaMN deleted the arc-234-test-ssc-humble branch January 30, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants