Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 Humble upgrade code only - not integration tested #166

Merged
merged 101 commits into from
Jan 22, 2025

Conversation

MishkaMN
Copy link
Contributor

@MishkaMN MishkaMN commented Dec 23, 2024

PR Details

Description

This is upgrade to Humble for ROS2 ssc-wrapper. Main changes are:

  • Separated the dockerfile into ROS1 (noetic) and ROS2 (humble). Thus splitting the dependency code as well from each dockerfiles
  • Added binary files from Hexagon (autonomoustuff) from CARMASensitive because it is not available in public repo list. They emailed it to us
  • Added message_filter::synchronizer that was used in autoware.ai before back here because foxy version of message_filter was not working at the time
  • Removed unnecessary git clones for ROS2 because all of the required packages are available as Humble deb file.
  • Removed dependency from autoware.ai because previously we separated all that carma-ssc-interface-wrapper needs from autoware.ai
  • Now this PR makes it generate 2 different images with following tags:
  • usdotfhwastoldev/carma-ssc-interface-wrapper:develop-humble
  • usdotfhwastoldev/carma-ssc-interface-wrapper:develop-noetic

Related GitHub Issue

NA

Related Jira Key

ARC-199

Motivation and Context

Upgrade to Humble

How Has This Been Tested?

For now it is only whether if the Docker image builds or not.
Next story will be integration testing in Lexus.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN requested a review from adev4a January 10, 2025 21:00
@MishkaMN MishkaMN self-assigned this Jan 10, 2025
@MishkaMN MishkaMN added the enhancement New feature or request label Jan 10, 2025
.circleci/config.yml Outdated Show resolved Hide resolved
@MishkaMN MishkaMN requested a review from adev4a January 22, 2025 05:33
@MishkaMN MishkaMN merged commit b768d2b into develop-humble Jan 22, 2025
2 of 3 checks passed
@MishkaMN MishkaMN deleted the arc-199-humble-upgrade branch January 22, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants