Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: reworking error toast notifications #18172

Merged
merged 16 commits into from
Feb 12, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
todo
nielslyngsoe committed Jan 30, 2025

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit 32a2bab4f0dc5d57889971f2c139112e00df2974
Original file line number Diff line number Diff line change
@@ -32,6 +32,7 @@ export class UmbResourceController extends UmbControllerBase {
* @param promise
*/
static async tryExecute<T>(promise: Promise<T>): Promise<UmbDataSourceResponse<T>> {
// TODO: tryExecute should not take a promise as argument, but should utilize the class property `#promise` instead. (In this way the promise can be cancelled when disconnected)
try {
return { data: await promise };
} catch (error) {