Feature: reworking error toast notifications #18172
Open
+275
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nielslyngsoe for reference it would be nice with syntax highlighting for e.g. JSON. |
# Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/notification/notification.context.ts
iOvergaard
reviewed
Jan 31, 2025
There was a problem hiding this comment.
There is a warning that options is not being used anymore. Is that a mistake?
| @@ -0,0 +1,43 @@ | |||
| import { customElement, html, ifDefined, nothing, property } from '@umbraco-cms/backoffice/external/lit'; | |||
| import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element'; | |||
| import type { UmbNotificationHandler } from '../../notification-handler'; | |||
There was a problem hiding this comment.
Suggested change
| import type { UmbNotificationHandler } from '../../notification-handler'; | |
| import type { UmbNotificationHandler } from '../../notification-handler.js'; |
| import { EventMessageTypeModel } from '@umbraco-cms/backoffice/external/backend-api'; | ||
| import type { UmbNotificationColor } from './types'; |
There was a problem hiding this comment.
Suggested change
| import type { UmbNotificationColor } from './types'; | |
| import type { UmbNotificationColor } from './types.js'; |
| @@ -0,0 +1,17 @@ | |||
| import { UmbModalToken } from '@umbraco-cms/backoffice/modal'; | |||
| import type { UmbPeekErrorArgs } from '../../types'; | |||
There was a problem hiding this comment.
Suggested change
| import type { UmbPeekErrorArgs } from '../../types'; | |
| import type { UmbPeekErrorArgs } from '../../types.js'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making errors appear in a dialog + displaying errors for both 'detail'(string) and 'errors'(json).
See screenshots:
Case 1:
Insert this somewhere in a Server Controller code:
throw new NotImplementedException();Case 2
Remove the front-end code of
${umbBindToValidation(this)}from name input insrc/Umbraco.Web.UI.Client/src/packages/templating/templates/workspace/template-workspace-editor.element.ts.