Andrewshen mapping prototype -> Eric's global mapping optimization system#193
Draft
andrew-shc wants to merge 61 commits intomainfrom
Draft
Andrewshen mapping prototype -> Eric's global mapping optimization system#193andrew-shc wants to merge 61 commits intomainfrom
andrew-shc wants to merge 61 commits intomainfrom
Conversation
…aggregated upon query (#86)
…d log messages for clarity
Open
13 tasks
Member
|
Big if true! I'll test this right away |
Member
|
|
EricPedley
requested changes
May 24, 2025
Member
EricPedley
left a comment
EricPedley
left a comment
There was a problem hiding this comment.
doesn't work. See my last comment. I don't know which is wrong: if mask is supposed to be larger of mask2 is supposed to be smaller, so it's up to you to fix this.
Contributor
Author
|
Using scale factor = 2. (lower it is better it is but slower) |
…rge/uavf_2025 into andrewshen-mapping-prototype
Member
|
This needs more work before it's ready to merge. A lot of the time even running offline it still fails to stitch better than the initial guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the global optimization by providing masks for the corresponding global cropped image.
Test Plan
Issues