Integrate differentiable homography optimization with mapping system#187
Closed
EricPedley wants to merge 20 commits intomainfrom
Closed
Integrate differentiable homography optimization with mapping system#187EricPedley wants to merge 20 commits intomainfrom
EricPedley wants to merge 20 commits intomainfrom
Conversation
… an angle in photos
if we need the sift homography optimization back we can just use the git history
Member
Author
|
killing this branch so there's just one PR up with #193 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Does what it says. Rn it's a draft because we need the parent branch to be merged in, plus it doesn't look like this is doing anything, which is probably a bug rather than the algorithm not working.
Test Plan
Check out this branch on the lab pc and run
map_from_logsin the debugger after editing the hard-coded path to use the lab pc's username.