-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Refactor changed files integration #9643
Conversation
5af75ff
to
2332d86
Compare
Request for commentsWould a love a feedback, positive as negative ! on the suggested implementation from there. ( Could be applied to ci-front and so on ) |
a9b0ddf
to
978a502
Compare
a03237d
to
553a932
Compare
3be57d2
to
00a4732
Compare
@charlesBochet we should get in touch after this being merged to update the org |
a190497
to
0db332f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR refactors GitHub Actions workflows by centralizing file change detection logic and improving failure handling across CI pipelines.
- Added new
.github/workflows/changed-files.yaml
as a reusable workflow that handles file change detection for all CI jobs - Upgraded from tj-actions/changed-files@v11 to @v45 to eliminate set-output usage warnings
- Added
ci-*-status-check
jobs across workflows to properly aggregate and handle job failures/cancellations - Simplified workflow structure by removing redundant conditional checks from individual steps and centralizing them in prerequisites jobs
8 file(s) reviewed, 11 comment(s)
Edit PR Review Bot Settings | Greptile
Log
|
BEFORE
run
AFTER
run
Motivations:
cons:
ci-NAME-status-check
needs list to any other existing and should be dep jobsVersion migration
Migrated to the latest
changed-files@45
version, getting rid of theset-output
usage warningsTests runs:
With mutation:
inner
job failedci-server-status-check
also has thecancelled
statusWithout mutation:
inner
job butci-server-status-check
still succeededNotes
Linter
We should setup a
yml
prettier and linter for the.github/worfklows
folderCentralized
ci-NAME-status-check
logicUnfortunately I couldn't achieve to either make a
composite
action or areusable-workflow
, as I could not access the correct layer to run thealways
but also acessing theneeds
context