Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][NITPICK]: Rename prerequisites jobs to changed-files-check #9670

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

prastoin
Copy link
Contributor

@prastoin prastoin commented Jan 16, 2025

Related to #9643

Renaming prerequisites jobs to a more accurate changed-files-check

@prastoin prastoin marked this pull request as ready for review January 16, 2025 12:51
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR renames the 'prerequisites' job to 'changed-files-check' across all CI workflow files for better clarity and consistency.

  • Renamed job in 7 workflow files: ci-chrome-extension.yaml, ci-front.yaml, ci-server.yaml, ci-shared.yaml, ci-website.yaml, ci-e2e.yaml, and ci-test-docker-compose.yaml
  • Updated all job dependencies (needs fields) to reference the new job name
  • Updated conditional statements that check job outputs
  • Maintains original workflow logic and functionality while using more descriptive naming

7 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Weiko Weiko merged commit 560f715 into main Jan 16, 2025
35 checks passed
@Weiko Weiko deleted the nitpick-rename-prerequisites-jobs branch January 16, 2025 13:10
Copy link

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-284ac0bb.json

Generated by 🚫 dangerJS against 2081dc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants