v4-dev: NES Edition #39783
Closed
v4-dev: NES Edition #39783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
| > | ||
| or consider | ||
| <a | ||
| href="https://www.herodevs.com/support/nes-bootstrap?utm_source=Bootstrap_site&utm_medium=Banner&utm_campaign=v4_eol" |
There was a problem hiding this comment.
I'm wondering if it wouldn't be better for the users to have a link to the new end-of-life page to have some information, and then they can decide whether or not they want to go to the HeroDevs website.
There was a problem hiding this comment.
@edezekiel Any thoughts on this from the HeroDevs side? I too am wondering about linking to this new page. We could add a third link to the banner, but I imagine that's some diminishing returns and fatigue to users.
Co-authored-by: Julien Déramond <[email protected]>
Merged
|
Deployed to production docs in #39786. We'll keep this branch around to work off of for future v4.x updates for NES, but otherwise is not needed and can close. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #39750 with fixes to make v4 docs run locally for me. Purpose of this is to establish a derivative of
v4-devthat is explicitly for our NES related changes to the docs. No official release here is planned./cc @edezekiel