Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 dev herodevs never ending support links and page #39750

Conversation

edezekiel
Copy link
Contributor

@edezekiel edezekiel commented Mar 6, 2024

Description

Update Bootstrap Docs with HeroDevs Never-Ending Support Links and more info about end of life status for Bootstrap 3 and 4.

Motivation & Context

Introduces Never-Ending Support for Bootstrap.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

^Link is broken, it appears that live deploy may not be functional for the v4-dev branch.

Related issues

@edezekiel edezekiel requested a review from a team as a code owner March 6, 2024 16:57
@julien-deramond julien-deramond marked this pull request as draft March 7, 2024 14:44
@jwcalles
Copy link

jwcalles commented Mar 7, 2024

@mdo here are the additions to the v4 docs that we discussed. There was some confusion on our end if this is the correct branch for the PR, so if this is not correct we will await your instructions on where is the correct place.

This PR adds the banner on the top of the v4 docs pointing users to the newly added "End of Life Status" page with some options for those still using v3 or v4 of bootstrap.

@edezekiel and our team are happy to make changes/edits as requested by you and your team.

@mdo
Copy link
Member

mdo commented Mar 8, 2024

@jwcalles @edezekiel Sorry for the delay! Our old docs versions aren't automatically previewed or pushed out to production anymore, so it's a manual process. We can merge these things into v4-dev and v3-dev, but then we'd have to build the files and manually add them to the gh-pages branch.

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things to review after testing locally. Will continue to see if I can get v4-dev running locally so we can build this and then push it to production.

@@ -0,0 +1,66 @@
---
layout: docs
title: End of Life Status for Bootstrap 3 & 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's shorten this and scoped to this particular version.

Suggested change
title: End of Life Status for Bootstrap 3 & 4
title: End of Life for Bootstrap 4

toc: true
---

Bootstrap 3 reached end of life July 24, 2019, followed by Bootstrap 4 on January 1, 2023. As such, neither version receives new features, updates, or security fixes. However, both are still available on all existing distribution channels (CDNs, package managers, GitHub, etc).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Bootstrap 3 reached end of life July 24, 2019, followed by Bootstrap 4 on January 1, 2023. As such, neither version receives new features, updates, or security fixes. However, both are still available on all existing distribution channels (CDNs, package managers, GitHub, etc).
Bootstrap 3 was released over a decade ago in August 2013, and Bootstrap 4 over six years ago in January 2018. Since then, millions of people have learned Bootstrap, prototyped with it, and shipped some amazing sites and apps with it. While Bootstrap 5 is continuing that journey with developers all over the world, there are still tons of those teams living on an older version of Bootstrap with limited to no support. Until now.
Bootstrap 3 reached end of life July 24, 2019, followed by Bootstrap 4 on January 1, 2023. As such, neither version receives new features, updates, or security fixes. However, both are still available on all existing distribution channels (CDNs, package managers, GitHub, etc).

---
layout: docs
title: End of Life Status for Bootstrap 3 & 4
description: Bootstrap 3 was released over a decade ago in August 2013, and Bootstrap 4 over six years ago in January 2018. Since then, millions of people have learned Bootstrap, prototyped with it, and shipped some amazing sites and apps with it. While Bootstrap 5 is continuing that journey with developers all over the world, there are still tons of those teams living on an older version of Bootstrap with limited to no support. Until now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorter title to match other pages.

Suggested change
description: Bootstrap 3 was released over a decade ago in August 2013, and Bootstrap 4 over six years ago in January 2018. Since then, millions of people have learned Bootstrap, prototyped with it, and shipped some amazing sites and apps with it. While Bootstrap 5 is continuing that journey with developers all over the world, there are still tons of those teams living on an older version of Bootstrap with limited to no support. Until now.
description: Get ongoing support, security fixes, and more with Bootstrap 4 thanks to Never-Ending Support from the folks at HeroDevs.

@@ -90,3 +90,4 @@
- title: Brand
- title: License
- title: Translations
- title: End of Life
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- title: End of Life
- title: End of Life

@mdo mdo mentioned this pull request Mar 14, 2024
@mdo
Copy link
Member

mdo commented Mar 14, 2024

Review comments and more addressed in #39783. Closing for that new branch that we can ideally use for future updates.

@mdo mdo closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants