Vite fix max recursion

[jeffreykthomas]

Added to @evanscho pull request some changes to Flipbook.vue to change the reactivity of minX and maxX. Eliminates the maximum recursive error I was receiving.

[Miml319]

hi, I have some problems in the use of page turning effect, can you help me？ The page-turning effect is split into 10 separate effects that are not linked together

[jeffreykthomas]

I think I have the same issue with the vite version, though I wouldn't describe as not linked together. However, for me this is much better than the original with the recursion error. I'm not sure why the difference, other than perhaps it doesn't redraw as many times as the original package.

vite-flip.mov

[sharon-alexander]

Same problem

[xoriuz]

Hi there, I've found a way to fix this issue, what should be the best way for me to contribute? I'm new in contribution, so would appreciate a step by step guide for me to create the pull request?

@jeffreykthomas @evanscho

[jeffreykthomas]

Oh cool; here is one way you could proceed:

1. Fork the repository with my edits (or you could start from the main branch and create brand new request):

   • Go to https://github.com/jeffreykthomas/flipbook-vue
   • Click the "Fork" button in the top-right corner of the page
   • This will create a copy of this repository in your GitHub account

2. Clone the fork:

   • Open a terminal on your local machine
   • Run the following command (replace your-username with your GitHub username):

     git clone https://github.com/your-username/flipbook-vue.git

3. Navigate to the cloned repository:

   cd flipbook-vue

4. Create and switch to a new branch based on my vite-fix-max-recursion branch, you can name it what you think is appropriate:

   git fetch origin
   git checkout -b fix-choppy-animation origin/vite-fix-max-recursion

5. Make the necessary changes to fix the error:

   • Open the project in your preferred code editor
   • Implement the solution you've found

6. Commit the changes:

   git add .
   git commit -m "Fix choppy animation in vite configuration"

7. Push the changes to your fork:

   git push origin fix-choppy-animation

8. Create a pull request to my vite-fix-max-recursion branch:

   • Go to your forked repository on GitHub
   • Click on "Pull requests" tab
   • Click the "New pull request" button
   • Set the base repository to jeffreykthomas/flipbook-vue
   • Set the base branch to vite-fix-max-recursion
   • Set the compare branch to your fix-choppy-animation branch
   • Click "Create pull request"
   • Add a descriptive title and explain the changes in the description
   • Click "Create pull request" again to submit

After you've completed these steps, I'll be able to review the changes and incorporate them into this original pull request. This process allows you to contribute directly to the work I and @evanscho have done while maintaining the integrity of the original pull request.

[muhammadshafie]

Hi @jeffreykthomas , I found a solution to the page-turning effect animation issue as I throughly read the working flipbook-vue library from https://github.com/Gladesinger/flipbook-vue3 and compare with your code. This library from Gladesinger working fine but the centering page function during flip (situation from single page to double spread page) is not working properly.

By changing the variable of dRotate in makePolygonArray method to 'let' and assigned it to negative value once it face back will eliminate the page-turning effect animation issue.

Screenshot attached below,

You may try from your end, hopefully this will help