Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Maximum recursive updates exceeded when trying to use the library #111

Open
p1pah opened this issue Feb 23, 2024 · 14 comments
Open

Comments

@p1pah
Copy link

p1pah commented Feb 23, 2024

Good evening,

I have attempted to use this library in vue3 a couple of times now, but have had 0 luck. I can't get it working with even the most basic of examples. Try turning the page by clicking or dragging on the image, and you will see in the console that the library yields:
Uncaught (in promise) Maximum recursive updates exceeded. This means you have a reactive effect that is mutating its own dependencies and thus recursively triggering itself. Possible sources include component template, render function, updated hook or watcher source function.

Any help would be greatly appreciated, attached is a code sandbox to replicate the issue..

Codesandbox:
https://codesandbox.io/p/devbox/flipbook-vue3-trwkdm?file=%2Fsrc%2FApp.vue%3A2%2C1

@p1pah
Copy link
Author

p1pah commented Feb 23, 2024

image

@Pikiko14
Copy link

Pikiko14 commented Mar 3, 2024

U solve this issues??

@p1pah
Copy link
Author

p1pah commented Mar 4, 2024

@Pikiko14 I did, anyone running into this, it is something to do with the package-lock.json file. Make sure you fork the repo from github rather than cloning the npm package. Once I forked the repo, it worked like 🧈

@itr-tayyababbas
Copy link

itr-tayyababbas commented Sep 16, 2024

vue 2 related npm package is working fine but after migration into vue 3 the updated vue 3 flipbook version is producing this error
Uploading Screenshot 2024-09-16 at 12.29.49 PM.png…

@p1pah
Copy link
Author

p1pah commented Sep 17, 2024

@itr-tayyababbas it's a package-lock.json issue, you need the one from his repo...

@nieyankai
Copy link

I've got the same error, any solutions?

@p1pah
Copy link
Author

p1pah commented Sep 30, 2024

@nieyankai you need to fork his repo, it has the correct resolution for the package-lock.json file..

@jeffreykthomas
Copy link

I get the same error when I use the <script src="https://unpkg.com/flipbook-vue"></script>

But when I fork the repo and try to roll it up I get other errors during the roll up regarding mismatched package versions.

I can get it to work within a project I build using vite or web pack, but currently I need to import the library using an external source.

Has anyone had success building a js or min.js file that doesn't produce the recursive error?

@jeffreykthomas
Copy link

jeffreykthomas commented Oct 1, 2024

This is the error during rollup

I git clone the project
cd to directory
npm install
npm run dist

Vue packages version mismatch:

- [email protected] (/Users/jeffreythomas/Documents/flipbook-vue3/node_modules/vue/index.js)
- [email protected] (/Users/jeffreythomas/Documents/flipbook-vue3/node_modules/vue-template-compiler/package.json)

This error is because I'm using vue3 which doesn't use vue-template-compiler...

@jeffreykthomas
Copy link

I migrated to @evanscho pr, and was able to build the js files, but still received the maximum recursive error.
Made some changes to Flipbook.vue, in particular regarding the reactivity of minX and maxX. Will pr with all the changes that eliminated the errors

@jeffreykthomas
Copy link

Pr here: #116

@peaeater
Copy link

I had this problem while using Vue 3.5.12. When I rolled back to Vue 3.4.38 (the last release on the 3.4.x branch), the problem went away. I also tried @jeffreykthomas PR with 3.5.12, and that worked too, except that the page flip animation contains a number of jagged artifacts, as somebody already pointed out in comments on that PR. Which is a shame, because otherwise great work by @jeffreykthomas (and @evanscho).

@alectrocute
Copy link

I had this problem while using Vue 3.5.12. When I rolled back to Vue 3.4.38 (the last release on the 3.4.x branch), the problem went away. I also tried @jeffreykthomas PR with 3.5.12, and that worked too, except that the page flip animation contains a number of jagged artifacts, as somebody already pointed out in comments on that PR. Which is a shame, because otherwise great work by @jeffreykthomas (and @evanscho).

@peaeater Have you found a solution to the jagged artifacts?

@n4ff4h
Copy link

n4ff4h commented Jan 26, 2025

I had this problem while using Vue 3.5.12. When I rolled back to Vue 3.4.38 (the last release on the 3.4.x branch), the problem went away. I also tried @jeffreykthomas PR with 3.5.12, and that worked too, except that the page flip animation contains a number of jagged artifacts, as somebody already pointed out in comments on that PR. Which is a shame, because otherwise great work by @jeffreykthomas (and @evanscho).

Hi thanks, this worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants