feat(pool): add AdaptiveAvgPool3d kernels - #521
Open
jcwal1516 wants to merge 1 commit into
Open
Conversation
2 tasks
jcwal1516
force-pushed
the
branch/adaptive-avg-pool3d-local
branch
from
August 21, 2026 16:40
b8ddfb5 to
27d9bf4
Compare
jcwal1516
force-pushed
the
branch/adaptive-avg-pool3d-local
branch
from
August 26, 2026 05:22
27d9bf4 to
604d51a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate your PR with burn.
It is important that you make sure that you don't introduce any bugs in burn.
Instructions
Burn validation: tracel-ai/burn#5372 at Burn commit
f62594eb975f04d2d95bb0c728bc1e47484dc588. It pins this PR's Cubek revision604d51ac0403ecbe06156c958ac458ca45a550e6.Related issue: tracel-ai/burn#5288.
Context
This replaces #497, which GitHub automatically closed after #495 merged and its base branch was deleted. The AdaptiveAvgPool3d feature patch is unchanged; the branch is rebased directly on Cubek
mainat22b77ade29af26a41dac872afb9f02b5a1bd8010.Changes
f32before casting to the output element type.PoolBackwardProblemconsistently represents channels-last tensors after generalizing the CPU reference.Testing
Passed against Cubek revision
604d51ac0403ecbe06156c958ac458ca45a550e6:cargo xtask check formatcargo xtask check lintcargo xtask check typoscargo xtask check auditcargo clippy --tests --features extended -- -D warningscargo clippy -p cubek-matmul --no-default-features --features std,tiled,extended,cubecl/cpu --tests -- -D warningscargo clippy -p cubek-matmul --no-default-features --features std,multi-level,extended,cubecl/cpu --tests -- -D warningscargo xtask doc buildcargo xtask doc testscargo test-metal-light -p cubek-pool -- --nocapture— 55 passed, 0 failed, 10 ignoredcargo test-cpu-light -p cubek-pool -- --nocapture— 55 passed, 0 failed, 10 ignoredcargo run-checks --backend metal— passed the complete canonical check, including both full Metal backend suitescargo xtask doc buildcargo xtask doc testscargo metadata --format-version 1 --locked --no-depsHosted Cubek CI on this exact commit passed code quality, documentation, and both stable and previous Linux jobs.
Hosted Burn CI on the exact linked Burn commit passed every job, including code quality, documentation, macOS Metal, stable and previous Linux jobs, stable Windows jobs, no-std, and coverage upload.
Before this rebase, the byte-identical feature implementation also passed WSL2/Linux CUDA and native Windows CPU/CUDA
cubek-poolruns — 55 passed and 10 ignored in each configuration.Confirmed baseline exception:
cargo xtask test --cireaches the unrelatedcubek-reducefailurereduce::it::reduce_dim::perpendicular_matrix_large_odd_batch::f32::parallel_vectorization_enabled::full_unit::reduce_dim::test_topk_with_indices_3. The identical isolated failure reproduces on clean Cubekmainat22b77ade29af26a41dac872afb9f02b5a1bd8010. Thecubek-poolportion passes 55 tests with 10 ignored, and hosted Linux CI passes on the exact PR commit.No benchmarks were added or used, and this PR makes no performance claim.