feat(cubecl): support AdaptiveAvgPool3d - #5372
Draft
jcwal1516 wants to merge 1 commit into
Draft
Conversation
4 tasks
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (55.55%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5372 +/- ##
==========================================
- Coverage 67.71% 67.68% -0.03%
==========================================
Files 1256 1256
Lines 194779 194878 +99
==========================================
+ Hits 131888 131912 +24
- Misses 62891 62966 +75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
laggui
reviewed
Aug 18, 2026
laggui
marked this pull request as draft
August 18, 2026 14:59
jcwal1516
force-pushed
the
branch/adaptive-avg-pool3d-local
branch
from
August 20, 2026 17:54
7433bcc to
d9e9a93
Compare
4 tasks
jcwal1516
force-pushed
the
branch/adaptive-avg-pool3d-local
branch
4 times, most recently
from
August 21, 2026 21:27
bce823f to
00ef08d
Compare
jcwal1516
force-pushed
the
branch/adaptive-avg-pool3d-local
branch
from
August 26, 2026 06:15
00ef08d to
f62594e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
cargo run-checkshas been executed.No book change is required because AdaptiveAvgPool3d is already part of Burn's public tensor API; this PR adds CubeCL backend support for the existing operation.
Related Issues/PRs
604d51ac0403ecbe06156c958ac458ca45a550e6.Changes
This does not change Burn's public API, fallback behavior for other backends, or quantization behavior.
Testing
Passed on Burn commit
f62594eb975f04d2d95bb0c728bc1e47484dc588against Cubek revision604d51ac0403ecbe06156c958ac458ca45a550e6:BURN_DEVICE=metal cargo test --release -p burn-backend-tests --no-default-features --features metal,std adaptive_avgpool3d -- --nocapture— 32 passed
BURN_DEVICE=metal cargo test --release -p burn-backend-tests --no-default-features --features metal,std,fusion adaptive_avgpool3d -- --nocapture— 32 passed
cargo run-checks --backend metalcargo xtask doc buildcargo xtask doc testscargo metadata --format-version 1 --locked --no-depsgit diff origin/main...HEAD --checkcargo run-checks --backend metalpassed on this exact Burn commit against the exact Cubek revision, including formatting, typos, audit, Clippy, no-std checks, and the complete Metal backend suites with and without fusion. Every AdaptiveAvgPool3d and FFT test passed.Hosted Cubek CI on the exact pinned revision passed every job.
Hosted Burn CI on this exact commit passed every job: code quality; documentation build and tests; macOS Metal; stable and previous Linux backends, crates, examples, and no-std; stable Windows backends, crates, and examples; and coverage upload.
The hosted Linux coverage matrix does not exercise these backend-specific lines: its backend shard tests Ndarray and Flex, while its crates shard excludes
burn-cubeclandburn-cubecl-fusion. The Metal suites above cover the changed CubeCL paths directly.Before this rebase, the byte-identical AdaptiveAvgPool3d implementation and tests also passed targeted no-fusion and fusion runs on WSL2/Linux CUDA and native Windows CUDA — 32 passed in each configuration.
No benchmarks were added or used, and this PR makes no performance claim.