Skip to content

Potential fix for code scanning alert no. 13: Type confusion through parameter tampering #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 13: Type confusion through parameter tampering #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/api/user/user.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,12 @@ export class UserController {
@Query('handle') handle: string,
): Promise<DTOs.ValidationResponseDto> {
this.logger.log(`Validating handle: ${handle}`);
if (!handle) {
throw new BadRequestException('Handle is required.');
if (
!handle ||
typeof handle !== "string" ||
(Array.isArray(handle))
Copy link

@github-actions github-actions bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[💡 maintainability]
The check Array.isArray(handle) is redundant since typeof handle !== 'string' already covers non-string types, including arrays. Consider removing it for simplicity.

) {
throw new BadRequestException('Handle is required and must be a string.');
}
return this.validationService.validateHandle(handle);
}
Expand Down
Loading