Skip to content

PM-2524 Fix empty submissions tab for DS F2F #7158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himaniraghav3 merged 3 commits into from
Dec 9, 2025
Merged

PM-2524 Fix empty submissions tab for DS F2F #7158

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d44ccb
PM-2524 Fix empty submissions tas for DS F2F
himaniraghav3 Dec 5, 2025
2eaecf7
cleanup
himaniraghav3 Dec 5, 2025
42d1e9b
remove track check
himaniraghav3 Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/shared/components/challenge-detail/Submissions/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,7 @@ class SubmissionsComponent extends React.Component {

isMM() {
const { challenge } = this.props;
const trackName = getTrackName(challenge);
return (trackName || '').toLowerCase() === 'data science' || checkIsMM(challenge);
return checkIsMM(challenge);
Copy link

@github-actions github-actions bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
The removal of the trackName check simplifies the isMM method, but it assumes that checkIsMM(challenge) alone is sufficient to determine if a challenge is a Marathon Match. Ensure that checkIsMM correctly encapsulates all necessary logic, as this change could affect the behavior for challenges that are not strictly Marathon Matches but were previously filtered by the trackName check.

}

/**
Expand Down
Loading