PM-2524 Fix empty submissions tab for DS F2F #7158
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const { challenge } = this.props; | ||
| const trackName = getTrackName(challenge); | ||
| return (trackName || '').toLowerCase() === 'data science' || checkIsMM(challenge); | ||
| return (trackName || '').toLowerCase() === 'data science' && checkIsMM(challenge); |
There was a problem hiding this comment.
[❗❗ correctness]
The change from || to && in the isMM function alters the logic significantly. Previously, the function returned true if the track name was 'data science' or if checkIsMM(challenge) was true. Now, both conditions must be true. Ensure this change aligns with the intended logic for determining if a challenge is a marathon match (MM). If this change was not intentional, it could lead to incorrect behavior when loading submissions.
| const { challenge } = this.props; | ||
| const trackName = getTrackName(challenge); | ||
| return (trackName || '').toLowerCase() === 'data science' || checkIsMM(challenge); | ||
| return checkIsMM(challenge); |
There was a problem hiding this comment.
[correctness]
The removal of the trackName check simplifies the isMM method, but it assumes that checkIsMM(challenge) alone is sufficient to determine if a challenge is a Marathon Match. Ensure that checkIsMM correctly encapsulates all necessary logic, as this change could affect the behavior for challenges that are not strictly Marathon Matches but were previously filtered by the trackName check.
@jmgasper I found the isMM var logic weird and changed it. This fixed the bug and now submissions are visible for Data Science F2Fs
LMK if that was intentional as Sathya told me there are some rules whch are different for DS mms and Dev mms