Skip to content

feat(incremental): ignore AWS CDK synth output #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tirth8205 merged 1 commit into from
Jul 17, 2026
+11 −0
Merged

feat(incremental): ignore AWS CDK synth output #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions code_review_graph/incremental.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ def _run_temporal_resolver(store: GraphStore) -> Optional[dict]:
# Dart / Flutter
"**/.dart_tool/**",
"**/.pub-cache/**",
# AWS CDK
"**/cdk.out/**",
# General
"/coverage/**",
"**/.cache/**",
Expand Down
9 changes: 9 additions & 0 deletions tests/test_incremental.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,15 @@ def test_root_output_defaults_do_not_hide_nested_source_directories(self):
patterns,
)

def test_cdk_output_default_matches_at_any_depth(self):
"""AWS CDK synth output is generated in root and monorepo projects."""
from code_review_graph.incremental import DEFAULT_IGNORE_PATTERNS

patterns = DEFAULT_IGNORE_PATTERNS
assert _should_ignore("cdk.out/manifest.json", patterns)
assert _should_ignore("packages/infra/cdk.out/asset.js", patterns)
assert not _should_ignore("packages/infra/cdk.output/source.ts", patterns)

def test_safe_dependency_defaults_still_match_at_any_depth(self):
"""The monorepo dependency case from #91 remains fixed."""
from code_review_graph.incremental import DEFAULT_IGNORE_PATTERNS
Expand Down